feat: add ARC mainnet in token scanning#9248
Closed
maxime-oe wants to merge 1 commit into
Closed
Conversation
maxime-oe
force-pushed
the
feat/add-arc-token-scanning
branch
from
a0e3aa3 to
593d7c2
Compare
Contributor
Author
|
Already included in #9506 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adds ARC mainnet to Token Scanning in phishing-controller.
DO NOT MERGE until https://github.com/consensys-vertical-apps/va-mmcx-security-alerts-api/pull/194 (API) is merged.
References
Checklist
Note
Low Risk
Single additive chain mapping with no auth or logic changes; effectiveness depends on the upstream API supporting
arc.Overview
Adds Arc mainnet to phishing-controller token scanning by mapping chain id
0x13b2toarcinDEFAULT_CHAIN_ID_TO_NAME, sobulkScanTokensand related flows can resolve the chain name when calling the security alerts API.The unreleased changelog entry documents the new network support. Deploy order: the matching security-alerts API change should land before this is merged.
Reviewed by Cursor Bugbot for commit 593d7c2. Bugbot is set up for automated code reviews on this repo. Configure here.